OpenPype icon indicating copy to clipboard operation
OpenPype copied to clipboard

Maya: vray/redshift multichannel exr image output prefix

Open m-u-r-p-h-y opened this issue 3 years ago • 6 comments

Running version 3.14.2

Describe the bug when using multichannel exr output in vray (6.00.02) wrong image ouptut prefix is applied to deadline job

image

Expected behavior with multichannel exr we should not use _<aov> image prefix

there is this check in renderproduct.py, but for whatever reason it is not working

[cuID:OP-4214]

m-u-r-p-h-y avatar Oct 10 '22 15:10 m-u-r-p-h-y

@m-u-r-p-h-y this is fixed by https://github.com/pypeclub/OpenPype/pull/3954

BigRoy avatar Oct 10 '22 17:10 BigRoy

It's odd that this happens with Multichannel EXR however - which makes me assume there's still another bug present. I feel both Redshift and V-Ray should not return <aov> appended from the render product if it's set to render as multilayer / merged AOVs to begin with. I feel like the logic might actually be wrong there.

BigRoy avatar Oct 10 '22 18:10 BigRoy

there is the logic, but I'm not able to tell why it is not working

        if image_format_str == "exr (multichannel)":
            # AOVs are merged in m-channel file, only main layer is rendered
            self.multipart = True
            return products

m-u-r-p-h-y avatar Oct 11 '22 08:10 m-u-r-p-h-y

I feel like the bug is here since it doesn't take into account whether it's multipart/multilayer or not. The same for Redshift actually.

BigRoy avatar Oct 11 '22 08:10 BigRoy

I feel like the bug is here since it doesn't take into account whether it's multipart/multilayer or not. The same for Redshift actually.

That's the problem there, wondering why it emerged suddenly. But it should be easy to fix.

antirotor avatar Oct 11 '22 09:10 antirotor

I suspect that with the refactor to new Deadline submitter we've started relying more on the lib_renderproducts implementation as the "ground truth" than before to avoid scattered around duplicated logic but that the lib_renderproducts actually was never implemented correctly for some of the cases like these.

BigRoy avatar Oct 11 '22 09:10 BigRoy