OpenPype icon indicating copy to clipboard operation
OpenPype copied to clipboard

Nuke: Validation refactory to new publisher

Open jakubjezek001 opened this issue 3 years ago • 2 comments

Brief description

Validators are compatible with New publisher

Description

  • Validate Backdrop
  • Validate Gizmo
  • Validate Asset Name
  • Validate Node's Knobs
  • Validate Render Output Resolution
  • Validate Proxy Mode
  • Validate Rendered Frames
  • Validate Script Attributes

Additional info

The rest will be ignored in changelog and should contain any additional technical information.

Documentation (add "type: documentation" label)

feature_documentation

Testing notes:

  1. start with this step
  2. follow this step

jakubjezek001 avatar Jul 25 '22 19:07 jakubjezek001

I tested in Nuke 12.2v3

  • [x] Validate Asset Name: tested on render and gizmo. Repair on render worked, on gizmo the repair removed the gizmo from the script

  • [x] Validate Gizmo: Correctly warns about more than one output

  • [x] Validate Proxy Mode: Correctly detects proxy mode, repair works

  • [x] Validate Script Attributes: Correctly detects and repairs fps, resolution,

  • [x] Validate Render Output Resolution: Correctly detects wrong reformat inside render group. Requires workfile to be published

  • [x] Validate Backdrop: Correctly detects "empty" backdrop

  • [x] Validate Rendered Frames: Seems to fail every time. With or without nuke slate in the script. Maybe the condition in ValidateRenderedFrames should just compare lengths? It looks like publish can ignore if artist renders more frames then necessary.

if (
    collected_frames_len != frame_length
):

Only available for "use existing frames" option.

  • [x] Validate Nuke Write Node: It fails on integer values:
Write node's knobs values are not correct!
Knob 'dw_compression_level' > Correct: `60` > Wrong: `60.0`
  • [x] Validate Node's Knobs: It didn't work for me with settings below. Validator didn't detect the review was off.
{
    "render": {
        "review": true
    }
}

jrsndl avatar Aug 08 '22 19:08 jrsndl

Task linked: OP-2222 nuke

ynbot avatar Aug 16 '22 15:08 ynbot

{
    "render": {
        "review": true
    }
}

Nice catch.. fixed now @jrsndl

jakubjezek001 avatar Aug 23 '22 15:08 jakubjezek001

Already removed OcioConfig submodule is added back to repository.

iLLiCiTiT avatar Aug 23 '22 15:08 iLLiCiTiT