OpenPype icon indicating copy to clipboard operation
OpenPype copied to clipboard

Deadline: Better AOV handling in submit job

Open iLLiCiTiT opened this issue 3 years ago • 2 comments

Description

Right now there is always used match_aov_pattern to find out if review should be created on farm but that doesn't make sense in most of DCCs. When Nuke, Photoshop, Aftereffects are sending job to farm they already know if review should be created and its' not based on AOV's. Right now there is quick hack using "useSequenceForReview" which works only for sequences and not single file outputs.

Expected behavior

Using AOVs to define if preview is based on AOVs should be turned off by default and triggered only if instance data contains some key (e.g. "useAovForReview"), otherwise use value from instance.data stored under very specific key (e.g. instance.data.get("reviewEnabled", False)).

[cuID:OP-3416]

iLLiCiTiT avatar Jun 15 '22 11:06 iLLiCiTiT

I wonder if we shouldn't be even more specific - be able to define review aovs (or the opposite) on publishing instance in creator. It would pull in the pattern (or list) from the Settings with sane defaults. This would allow artist to override default behaviour per scene basis.

antirotor avatar Jun 21 '22 07:06 antirotor

Not sure if that is responsibility of creator? Also it would be impossible to change it after creation, unless you would allow artists to change it (!).

iLLiCiTiT avatar Jun 22 '22 11:06 iLLiCiTiT