OpenPype icon indicating copy to clipboard operation
OpenPype copied to clipboard

FTrack: Note creation with empty intent

Open gabormarinov opened this issue 3 years ago • 3 comments

Describe the bug IntegrateFtrackInstance/IntegrateFtrackNote default Note template: {intent}: {comment}

If the user don't enter any intent or write any comment a Note sill being created in FTrack with content: -: which is the intent -, the separator : and an empty string.

To Reproduce Steps to reproduce the behavior:

  1. Switch on IntegrateFtrackInstance/IntegrateFtrackNote in settings with the defaults
  2. Publish anything without setting an intent or writing any comment
  3. Check the Note in FTrack

Expected behavior If the user don't set an intent or enter a comment, then don't create an FTrack note.

Screenshots Created note example: image

[cuID:OP-3178]

gabormarinov avatar May 03 '22 14:05 gabormarinov

@iLLiCiTiT we should probably make a condition there to skip the note provided both intent and comment are empty

mkolar avatar Jun 07 '22 21:06 mkolar

The intent is not empty but -. We should rather add ability to have "empty intent" so it is not needed to hack it using dash (or different symbol).

iLLiCiTiT avatar Jun 08 '22 09:06 iLLiCiTiT

I agree, however, then you'll still end up with : in the comment won't you?

mkolar avatar Jun 08 '22 10:06 mkolar