Rémy F.

Results 99 comments of Rémy F.

Confirmed working on Linux machine without CUDA

Hi, the simple reason is that - loading from Buffer is platform agnostic - loading from path/URL makes us platform adherent (node/browser/...) and because of that, we shall offer (and...

Latest mocha shall be usable when migrated to module https://github.com/opentypejs/opentype.js/pull/579

@ILOVEPIE / @Connum No urgency (since 2.0.0 is not so near), but I would like to get your feeling about it.

> Use dynamic imports Seems like the best solution so far, but unlike synchronous `require()`, the `import()` is asynchronous. This create funny prototype like [this](https://github.com/opentypejs/opentype.js/commit/c3ff71617d5b04343371a92d3cc43cff5c1aaa2f#diff-df450d6af8a7db11b9035ce8ed10647c34b891e04a0eb89aa6d121e745eb919cR480) may as well drop the...

> it just had to be declared as async to be able to use the await keyword. That's what `async` function are for. Having an `async loadSync()` declaration is laughable....

@Connum Here is what I did: - Used your `import()` strategy => work well :+1:, I added an `engines` field to the new package.json in order to reflect the `ES2020`...

@ILOVEPIE are you sure about that breakage ? because in this PR, I took the effort to make it backward compatible. so all previous path are still there and there...

Shall I rebase/resolve this PR or can it still wait ?

Understood, I'll be ready :)