mypy-playground icon indicating copy to clipboard operation
mypy-playground copied to clipboard

Published 20 hours ago • verified publisher icon ymyzk

(🎁) add pre-commit.ci to the project

Open KotlinIsland opened this issue 2 years ago • 2 comments

a lot of projects use it and it works very well in my experience.

https://pre-commit.ci/ https://github.com/marketplace/pre-commit-ci

KotlinIsland avatar Oct 12 '23 12:10 KotlinIsland

Thanks for the suggestion. Currently, we already run pre-commit using GitHub Actions + tox. There may benefit to use pre-commit.ci in addition to the GitHub Actions, but I don't feel that's necessarily a high priority for this project. I'd rather reserve time for implement features requested in issues.

ymyzk avatar Oct 15 '23 03:10 ymyzk

Pre-conmit.ci is simply a GitHub app that us added to the project, it would only take 10 seconds to do.

It has the capability to automatically fix issues in a PR (formatting/linting) and commit the fixes onto the branch.

It also runs a lot faster than pre-commit in a GitHub action.

KotlinIsland avatar Oct 15 '23 03:10 KotlinIsland