openy icon indicating copy to clipboard operation
openy copied to clipboard

ID's in the markup are tied to the theme name and cause CSS issues with activating a child theme.

Open mikemuller opened this issue 6 years ago • 6 comments

There are ID's that are added to the markup which reference the theme name. When a child theme is activated, the ID's change, breaking some of the styles on the page.

mikemuller avatar Sep 24 '18 02:09 mikemuller

Assigned IXM to dig into and discuss further with @podarok as needed

YMCA-GTC avatar Sep 27 '18 16:09 YMCA-GTC

As it was researched there are no any id which are connected with theme name. As I can see css issues are not connected with tying to the theme name. @kolesnikoff

SanyokMedved avatar Oct 18 '18 13:10 SanyokMedved

@mikemuller looks like we need your help to enlighten places where you faced with an issue Could you help?

podarok avatar Apr 05 '19 08:04 podarok

@mikemuller is this still an issue you are encountering? We are moving it to our Issue backlog until we hear more information from you. Thanks.

paige-kiecker avatar Jul 01 '19 18:07 paige-kiecker

@mikemuller this item will continue to stay in our backlog until we are able to get more details from you on the issue. @podarok recalls that the theme was removed from CSS classes and that this issue was possible addressed through that update. We will revisit in 3 months and we'll close out if we cannot replicate the issue.

sarah-halby avatar Oct 27 '20 15:10 sarah-halby

The issue is not fixed, the selectors by IDs still used. Here just a few examples, but in fact, there are more of them https://github.com/ymcatwincities/openy/blob/8.x-2.x/themes/openy_themes/openy_lily/sass/misc/_header.scss#L227 https://github.com/ymcatwincities/openy/blob/8.x-2.x/themes/openy_themes/openy_lily/sass/misc/_header.scss#L314 https://github.com/ymcatwincities/openy/blob/8.x-2.x/themes/openy_themes/openy_lily/sass/misc/_header.scss#L438 https://github.com/ymcatwincities/openy/blob/8.x-2.x/themes/openy_themes/openy_lily/sass/misc/_footer.scss#L15 https://github.com/ymcatwincities/openy/blob/8.x-2.x/themes/openy_themes/openy_lily/sass/misc/_footer.scss#L57 https://github.com/ymcatwincities/openy/blob/8.x-2.x/themes/openy_themes/openy_lily/sass/misc/_footer.scss#L75

afi13 avatar Nov 06 '20 08:11 afi13