coderev icon indicating copy to clipboard operation
coderev copied to clipboard

Breaks on svn::externals, Reverts code inside svn::externals

Open robotron2084 opened this issue 12 years ago • 2 comments

Thanks for the tool! It works really well, except it does have a minor issue when it hits svn::externals. It will hiccup and display something like:

  • MyProject/InteropStructs.h | Changed/Deleted/Added: 0/0/1
  • MyProject/Util/bmfont.cpp | Changed/Deleted/Added: 7/0/0
  • MyProject/Util/bmfont.h | Changed/Deleted/Added: 18/3/0
  • MyProjectTest/Assets/core | New file (skipped special/binary)
  • ing status on external item at 'MyProjectTest/Assets/core': | Not found

It then creates a folder called "ing status on external item at 'MyProjectTest". I think it is attempting to add the SVN_REPO-r281-2013-02-06.14.38.57 folder, and then creates this instead.

Thanks again for this utility, very promising regardless of this issue.

robotron2084 avatar Feb 06 '13 21:02 robotron2084

Ok, not cool. Turns out the utility just svn reverted the code I wrote inside the svn::externaled repository. Thankfully I did not lose an epic amount of work, but definitely a HUGE bug. I have been able to consistently reproduce the issue. :(

robotron2084 avatar Feb 06 '13 22:02 robotron2084

The design is very limited on top of patch, tar and not easy to extend, I am not surprise to see a new bug report here. :)

Maybe you can try https://github.com/ymattw/cdiff, with that tool you can just send raw diff for peer review.

I am about to take vacation for a couple of days and will be looking into this issue later.

ymattw avatar Feb 07 '13 01:02 ymattw