ylavic

Why is the *mutex NULL in the first place? And why would retrying work?

apr_global_mutex_child_init() is not supposed to be called with `*mutex == NULL` (it should have been allocated with apr_global_mutex_create() first), so this is a usage/user error (i.e. don't do that)? Also,...

The trunk and 1.7.x branches of APR improved compatibility with openssl 1.1 and latest libressl versions too. The proposed patch shouldn't be needed now.

It seems that there was an agreement in #7388 about allowing to disable atexit/pinning at init time, though it was later closed in favor of a build time only option...

The issue is that -znodelete can't be changed at init/runtime (cast in ELF stone), so would you agree on removing/ignoring the Configure [no-]pinshared and depend only on an first OPENSSL_crypto_init(OPENSSL_INIT_NO_PINSHARED)...

Can't the same be achieved by adding an `203.0.113.2:443 domain.tld` entry in `/etc/hosts` and simply using `ProxyPass / https://domain.tld` ?

> > In the test, the following got logged, which is a win: > > ``` > > {"remoteAddr":"127.0.0.1","size":"236","logicalUserName":"","request":"GET / HTTP/1.1","statusCode":"404","time":"[17/Dec/2023:19:52:58 +0000]","user":""} > > ``` > > > > In...

> Is this not going to waste a lot of disk space and cycles? > > Think of a time when we might be logging say 20 different attributes, and...

I (personnaly) think rebasing is fine in PRs/feature branches. Regarding the encoding, you are right that ap_escape_logitem() should already \\-escape controls, double quote and non-ascii characters, so there is nothing...

> another question: why does ap_escape_logitem() return a copy of the input string even if no escpaing is done, bascially duplicates all strings in mod_log_config? It returns a `char *`,...