StyleTTS2 icon indicating copy to clipboard operation
StyleTTS2 copied to clipboard

Do we need lr scheduler?

Open Dforgeek opened this issue 1 year ago • 3 comments

In all repository, I didn't find any place where scheduler.step() was used in training. Should it be this way?

Dforgeek avatar Jul 25 '24 15:07 Dforgeek

I've found step() function of scheduler being used on these lines: https://github.com/yl4579/StyleTTS2/blob/main/optimizers.py#L43-L45

Also, the lr_scheduler is being used here: https://github.com/yl4579/StyleTTS2/blob/main/optimizers.py#L54

All of that is used in imports of all training scripts as from optimizers import build_optimizer.

martinambrus avatar Aug 31 '24 15:08 martinambrus

It is true that there's single place where .step() is being called, иut the method .scheduler() in which .step() is called has never been used for any of the training scripts. So I think it's not used.

Dforgeek avatar Sep 02 '24 10:09 Dforgeek

I can confirm, at least for train_finetune.py, that the lrs are not adjusted for any of the models

ethan-digi avatar Sep 23 '24 17:09 ethan-digi