yktoo
Added: class function TDKLanguageManager.TryGetConstantValue(...): Boolean
Added TryGetConstantValue class method for retrieving a constant value without raising exceptions:
class function TDKLanguageManager.TryGetConstantValue(
const aName: UnicodeString;
out aValue: UnicodeString
): Boolean;
I've been traveling so I hadn't had much chance to review it. I don't see any issues with the code itself, but could you format your submitted code to the same standard that the rest of the project is using?
@bjmillerpa sorry for my late reply. By the format, do you mean that the entire method body is shifted to the right side by two spaces? I thought I accidentally done that and I can fix that. If you mean something else, can you point out? thanks.
That's most of it. Take a look at how the rest of the code is formatted and match it. I'd rather it be your commit that is used than my edit of it.
Bruce J. Miller 1-814-725-2312 voice 1-814-206-0362 fax
On Thu, Aug 2, 2018 at 4:11 AM, Edwin Yip [email protected] wrote:
@bjmillerpa https://github.com/bjmillerpa sorry for my late reply. By the format, do you mean that the entire method body is shifted to the right side by two spaces? I thought I accidentally done that and I can fix that. If you mean something else, can you point out? thanks.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/yktoo/dklang/pull/23#issuecomment-409844093, or mute the thread https://github.com/notifications/unsubscribe-auth/AArtcWiDOYNaw7AUPF1iDnJo9UVoXjYAks5uMrQ2gaJpZM4TeWwc .