s2-geometry-library icon indicating copy to clipboard operation
s2-geometry-library copied to clipboard

Published 20 hours ago • verified publisher icon yjwong

Fix compilation on linux/travis.

Open rubak opened this issue 7 years ago • 3 comments

The newest pull request by @socmag broke the build on travis CI (and on my machine) as seen here: https://travis-ci.org/spatstat/s2-geometry-library/builds/287482806

A fix in CMakeLists.txt made it compile on osx on travis as seen here: https://travis-ci.org/spatstat/s2-geometry-library/builds/287518806

Finally an issue with isnan and isinf already being defined for gcc/g++ needed to be fixed in exactfloat.cc for it to build on both platforms: https://travis-ci.org/spatstat/s2-geometry-library/builds/287530941

rubak avatar Oct 13 '17 12:10 rubak

Sorry about that, and thanks for fixing it.

socmag avatar Oct 22 '17 09:10 socmag

Actually I found out that @nebolsin has made many fixes to this library which would be great to merge. So maybe you should wait a bit with this pull request and see if he opens a pull request that fixes everything in one go. The only issue with his fork at the moment is that he didn't fix the OpenSSL >=1.1.0 issue yet, but maybe he will incorporate that as well. (Otherwise I will be willing to make a new pull request that merges this stuff.)

rubak avatar Oct 23 '17 10:10 rubak

Great, I saw some nice PR's on the other forks. Would be really nice to keep this mainline branch up to date and building without the dependencies that some of those have.

Again, cool stuff :+1:

socmag avatar Oct 23 '17 16:10 socmag