y-websocket

y-websocket copied to clipboard

When constructing messages to seend to a peer using y-websocket, the constants used to identify the type of message must be re-defined when the message is constructed because they're not...

aryzing

Added a comment to clarify why reply messages are not sent when their length is 1. Alternatively we could also create a function with a descriptive name of the check...

aryzing

Call onclose when closing the connection in the checkinterval

2

**Context** In Safari the Websocket does not call onclose when the socket is closed manually. **The problem** This means that if a connection is closed in the interval in Safari...

johnstleger

Hello there! When attempting to get a Hello World of `y-websocket` working as a client running node `v17.8.0`, I encountered a few errors regarding missing imports for `ws` in `src/y-websocket.js`....

kellydunn

Set type as ES Module

3

Huly®: YJS-718

davidbrochart

**Is your feature request related to a problem? Please describe.** Our ES server backend (EcmaScript, i.e. preferring "import" over "require") directly imports `utils.js`: ``` import * as yws from "y-websocket/bin/utils";...

canadaduane

Next major release: Make this a proper esm module

9

Note to myself: Make this a proper ESM module by setting `type: "module"` in package.json. Currently, the `bin` folder contains commonjs modules (with file ending of `.js`) and the `src`...

dmonad

fix: rebase v2 branch off master to resolve conflicts

1

This PR rebases v2 off master to resolve conflicts on in package.json. Huly®: YJS-725

tyrauber

V2 branch - Transformed server to a proper ESM module

1

I also plan to remove some of the existing code. For example, there have been too many misunderstandings about the callback functionality. Huly®: YJS-726

dmonad

> Please save me some time and use the following template. In 90% of all issues I can't reproduce the problem because I don't know what exactly you are doing,...

szborows