Yixuan Qiu
Yixuan Qiu
The code did not pass the clang-format check, so I further edited this PR in the [develop](https://github.com/yixuan/spectra/tree/develop) branch. I feel it is already in good shape, and I will try...
Just noticed that I can edit the PR, so we can directly work on your branch. I just pushed the changes.
I found a compatibility issue here. The template `Eigen::Vector` in `KrylovSchurGEigsBase.h` was introduced by Eigen 3.4.0, so the code does not compile with Eigen 3.x.y. Could you make a simple...
I hope I can finish this soon. Just a quick question: for Hermitian matrices, Krylov-Schur is equivalent to the implicitly restarted Lanczos algorithm, it that correct? Because Schur decomposition on...
I just want to leave another comment to say sorry that I'm a bit tied up recently. I put this PR in a high priority, so once I get some...
Today I spent some time reading the whole implementation, and got a quick question to ask: from the title of this PR and our previous discussions it seems that you...
Oh, I mean, the A and B matrices can be both real-valued, but if A is not symmetric, then the eigenvalues and eigenvectors are supposed to be complex-valued, right? But...
Yeah, that will be super cool, and you are always welcome to contribute. One thing I need to think about is how to design the API and integrate JD into...
Nope, so far Spectra is still a very individual project and I mostly do manual editing. I used it for my own research, so formality was not the priority.
It doesn't matter, since I expect we need to do some refactoring first, and formatting comes later. Just remember to update the `AUTHORS.md` file to document the contribution.