ving
ving copied to clipboard
Building from source using Go 1.11 results in dependency issues if the user tries to use an old style project layout
Hi,
When using a go get -u in a project style directory layout with a GOPATH etc I see the following issues. Its not apparent from the install that the proper way to do this is using a clean checkout in a directory and without a GOPATH etc set.
# github.com/yittg/ving/ui
src/github.com/yittg/ving/ui/ui.go:253:2: undefined: termui.Handle
src/github.com/yittg/ving/ui/ui.go:260:2: undefined: termui.Handle
src/github.com/yittg/ving/ui/ui.go:280:3: undefined: termui.Handle
src/github.com/yittg/ving/ui/ui.go:290:3: undefined: termui.Handle
src/github.com/yittg/ving/ui/ui.go:303:2: undefined: termui.Handle
src/github.com/yittg/ving/ui/ui.go:305:3: undefined: termui.StopLoop
src/github.com/yittg/ving/ui/ui.go:314:2: undefined: termui.Handle
src/github.com/yittg/ving/ui/ui.go:333:2: undefined: termui.Handle
src/github.com/yittg/ving/ui/ui.go:340:2: undefined: termui.Loop
# github.com/yittg/ving/addons/port
src/github.com/yittg/ving/addons/port/ui.go:46:14: undefined: termui.Par
Go details
go version go1.11.4 linux/amd64
Git details are
## Remote URLs:
origin [email protected]:yittg/ving (fetch)
origin [email protected]:yittg/ving (push)
## Remote Branches:
origin/HEAD -> origin/develop
origin/develop
origin/master
## Local Branches:
* develop
## Most Recent Commit:
commit 2d59b75bdcfabbd48d51682dfa4dc84dacade7ff
Author: Yi Tang <[email protected]>
refactor: replace stop chan with context
It might be better to have the install instructions start with a git clone and mention unset of the GOPATH env var, for example:
cd ~/tmp/go && unset GOPATH && unset GOROOT && unset GOBIN=~/bin && GO111MODULE=on
git clone [email protected]:yittg/ving && cd ving && ~/go/bin/go install
This gives a good hint that we are not dealing with the older style project directory hierarchy that people from older versions of Go might be using.