Victoria Nadasdi
Victoria Nadasdi
Is this still relevant?
Related tests were disabled because they were flaky, now I tried to fix and enable them. Two related tests are still disabled[^1], please enable them as part of the fix...
As it was flaky and not failing all the time when it was disabled, we can assume it was introduced after we disabled those tests, I'll try to `git bisect`...
`git bisect` says this commit is the first `bad`: https://github.com/weaveworks/tf-controller/commit/374232a60fa89067661d47cfafaa1420b3c7d2d6 (but I don't see why would it cause this)
After a bit of poking, if I remove all changed from the commit, except the `patcher := ...` and the `patcher.Patch` call (so the `finalizeStatus` does literally nothing, but patches...
Note: It looks like some files have a modification date of `1970-01-01` (and most likely `01:00:00` for time).
The system uses [`tf-exec`](https://github.com/hashicorp/terraform-exec) to call terraform commands. The runner does not call `terraform` binary as a system command directly. As far as I know, Terragrunt is a wrapper around...
Does it require any code changes or it can be simply documented how to build and change images for the controller and runners (I think we have docs about that),...
You can, but I can't promise I'll have time to review in the near future as it requires changes we have to consider if we even want/can do. 1. It'll...
@renato0307 : Go for it, if any of us picked it up, we assign ourselves.