Yireo_Webp2 icon indicating copy to clipboard operation
Yireo_Webp2 copied to clipboard
verified publisher icon yireo

504 page when no review with product page

Open sunilit42 opened this issue 3 years ago • 5 comments

https://github.com/yireo/Yireo_NextGenImages/blob/master/Observer/ReplaceBlockHtml.php#L73

I think we need to add to condition if html contain sting then do that stuff, otherwise getting error

sunilit42 avatar Jul 29 '22 06:07 sunilit42

Could you please comment on what causes you to suggest this change? Is there an error or a warning? For which specific page would the transport of an HTML event when outputting a Magento page be blank?

jissereitsma avatar Jul 30 '22 15:07 jissereitsma

[2022-08-01 05:34:47] report.CRITICAL: Warning: DOMDocument::loadHTML(): Empty string supplied as input in /srv/public_html/vendor/yireo/magento2-next-gen-images/Util/HtmlReplacer.php on line 139

  • This is happen for ajax review loading on product page
  • open any product page, that does not contain any review
  • you will see this error loadHTML(): Empty string supplied as input into log file

sunilit42 avatar Aug 01 '22 05:08 sunilit42

Could you confirm the version you are using?

jissereitsma avatar Aug 01 '22 07:08 jissereitsma

"name": "yireo/magento2-webp2", "version": "0.12.1",

sunilit42 avatar Aug 01 '22 12:08 sunilit42

Thanks. Could you upgrade to the latest versions of NextGenImages and WebP2 to see if this fixes your issue? It would be a bit silly to troubleshoot issues that are already fixed.

jissereitsma avatar Aug 01 '22 12:08 jissereitsma