Yireo_NextGenImages icon indicating copy to clipboard operation
Yireo_NextGenImages copied to clipboard
verified publisher icon yireo

Supporting attributes which contains JSON data

Open dev-waltr opened this issue 1 year ago • 1 comments

With the changes from version 0.5.0 to version 0.5.1 it is not possible to have attributes which contains JSON-data like data-mage-init="{"Magento_Theme/js/imageMagnifier": {}}".

The nodeValue will strip everything after the initial curly braces which results in invalid html. By executing data-mage-init, which contains invalid JSON-data, it results into a JS error which breaks the frontend.

dev-waltr avatar May 08 '24 09:05 dev-waltr

Thanks for noticing. I think this is a simple change: https://github.com/yireo/Yireo_NextGenImages/commit/7a132a1faa1c9eb79205583d13043f7025bf5fe6 This will be included in version 0.5.3 that is out either today or tomorrow.

jissereitsma avatar May 22 '24 14:05 jissereitsma

I'm closing this due to inactivity. Let me know if this is not yet fixed already.

jissereitsma avatar Aug 09 '24 10:08 jissereitsma