yireo
Additional checks for XML files
Its great that the module supports XML files and i think the analysing these files can be improved.
For example, we have a module where we use xtento/productexport . In our custom export profiles, we use something like
<xsl:value-of select="php:functionString('number_format', php:functionString('Xtento\ProductExport\Helper\Xsl::currencyConvert', price, 'EUR'), 2, '.', '')"/>
As by default we have a dependency on Xtento, however the module suggests that this dependency is probably not needed. What would be the correct suggestion in this case ?
Phew, this is a tricky one. That XSL syntax is really module-specific. @jissereitsma, do you have a good idea how to approach this? I am not sure if it makes sense to include a check for this if only the XTENTO modules use this XSL PHP function call...
Maybe one idea would be to make the checker still pass even if dependencies are possibly not needed? It would be helpful if it would pass, but still report these "possibly not needed" depenencies IMHO. Currently, hide-needless is a hard switch. It either leads to an error or it does not report the issues at all.
