rounded-window-corners icon indicating copy to clipboard operation
rounded-window-corners copied to clipboard

Publish onto extensions.gnome.org?

Open Fenimoure opened this issue 1 year ago • 15 comments

It would be pretty nice to have this extension available that way. thanks.

Fenimoure avatar Nov 30 '23 17:11 Fenimoure

yes, please

khaustovdn avatar Dec 03 '23 00:12 khaustovdn

it is?

https://extensions.gnome.org/extension/5237/rounded-window-corners/

Aworldc avatar Dec 05 '23 09:12 Aworldc

I think he mean publish the update to extensions.gnome.org

cfouche3005 avatar Dec 05 '23 11:12 cfouche3005

is there anything stopping the upload of the new version to the site?

zbikk avatar Dec 06 '23 16:12 zbikk

is there anything stopping the upload of the new version to the site?

Looks like v12 was pushed to the gnome extensions website but the update was rejected. The issues seem pretty small.

https://extensions.gnome.org/review/47995

leaf-penguin avatar Dec 31 '23 08:12 leaf-penguin

This is kind of a duplicate of #147 by the way. Just linking the two together. :)

benjamin051000 avatar Dec 31 '23 14:12 benjamin051000

Here's a copy of the rejection notes (see link @leaf-penguin posted above):

  1. No need to use this.initTranslation() (line 18 prefs.js):

    Consider this method deprecated. Only specify gettext-domain in metadata.json. GNOME Shell can automatically initiate the translation for you when it sees the gettext-domain key in metadata.json.

    Port Guide 45: Extension Utils

  2. You should uninit_settings() in disable() and window close request in prefs.js.

    window.connect('close-request', () => {
        uninit_settings();
    });

benjamin051000 avatar Dec 31 '23 14:12 benjamin051000

Is it expected to be fixed soon? Or are any PRs open for it?

devNamanG avatar Jan 03 '24 08:01 devNamanG

What can we do to help make this happen? I am tired of snagging things on the sharp corners of my windows.

AJCxZ0 avatar Jan 10 '24 18:01 AJCxZ0

What can we do to help make this happen?

So basically you can follow the steps in the README and compile and install on your machine, I did the same, it's temporary till the extension comes up as supported on EGO for Shell v45.

devNamanG avatar Jan 12 '24 02:01 devNamanG

Thank you for the advice, @namangor04.

So basically you can follow the steps in the README...

Please excuse me for being insufficiently clear. By "this" I meant the purpose stated in the issue, i.e. to publish on Rounded Window Corners so that it gets automagically picked up and updated on GNOME 45+.

AJCxZ0 avatar Jan 14 '24 21:01 AJCxZ0

I guess someone could follow the feedback in the rejection note and make a PR, then wait for the author to approve and re-push to gnome extensions. However, by the looks of things on this repo, I think the author is either busy with life, or otherwise MIA.

coolkys avatar Jan 15 '24 03:01 coolkys

For anyone interested I have packed 63 various extensions, including RWC, that are compatible with Gnome 45.2 in a repo. (https://github.com/in4matix/Gnome45-Extensions)

in4matix avatar Jan 15 '24 07:01 in4matix

For anyone interested I have packed 63 various extensions, including RWC, that are compatible with Gnome 45.2 in a repo. (https://github.com/in4matix/Gnome45-Extensions)

Your repo should be the de facto way to install this extension in Gnome 45 for now. Thanks!

coolkys avatar Jan 16 '24 10:01 coolkys

For anyone interested I have packed 63 various extensions, including RWC, that are compatible with Gnome 45.2 in a repo. (https://github.com/in4matix/Gnome45-Extensions)

Thanks for the time spent doing this, I have starred your repo and was missing this extension to run alacritty with no decoration and the same gnome rounded corners I have in Debian

Memnoc avatar Jan 31 '24 20:01 Memnoc