Yijie Wang

Results 28 comments of Yijie Wang

> Awesome, this looks great @yijie-04 ! I think we just need to add a few unit tests then we can merge! If you have any questions about the unit...

@Cali0707 The error message I'm still getting is: `--- FAIL: TestAllCases (0.33s) --- FAIL: TestAllCases/subscription_goes_ready_with_channel_in_different_namespace (0.32s) /Users/yijiewang/go/src/knative.dev/eventing/pkg/reconciler/subscription/subscription_test.go:2559: Reconcile() error = failed to get userInfo, which is needed to validate access...

Hey @Cali0707 I think the user info is good now! But I think it's having trouble creating subject access reviews. I also tried giving it a fake host value but...

@Cali0707 @pierDipi I think the authorization is working correctly now but there's an unexpected action error. I'll keep debugging and see what I can find. ```=== RUN TestAllCases === RUN...

@Cali0707 @pierDipi I think the new files are having trouble with the tabs/spaces again :( Could you help formatting the them?

Oops I didn't see you added the lgtm label, could you add it again @Cali0707? I corrected the resources.