yii2 icon indicating copy to clipboard operation
yii2 copied to clipboard
verified publisher icon yiisoft

Fix #20239: fix `yii\data\ActiveDataProvider` to avoid unexpected pagination results with UNION queries

Open Izumi-kun opened this issue 11 months ago • 7 comments

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌
Fixed issues #20239

Related PR: #20246

Izumi-kun avatar Jan 15 '25 12:01 Izumi-kun

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.86%. Comparing base (4859c8f) to head (efb8b5e).

Additional details and impacted files 
@@             Coverage Diff              @@
##             master   #20311      +/-   ##
============================================
+ Coverage     64.85%   64.86%   +0.01%     
- Complexity    11435    11437       +2     
============================================
  Files           431      431              
  Lines         37193    37203      +10     
============================================
+ Hits          24120    24131      +11     
+ Misses        13073    13072       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 15 '25 12:01 codecov[bot]

Let's exclude composer.lock changes.

samdark avatar Jan 15 '25 18:01 samdark

@rob006 would you please take a look?

samdark avatar Jan 15 '25 18:01 samdark

I don't really like the implementation, it looks like a workaround. The design of the query build doesn't allow for a more proper solution without breaking BC. Or am I missing something?

Izumi-kun avatar Jan 17 '25 05:01 Izumi-kun

Moved to next milestone for now.

samdark avatar Feb 13 '25 17:02 samdark

@Izumi-kun any idea about better solution?

samdark avatar Feb 14 '25 11:02 samdark

@Izumi-kun any idea about better solution?

No any new solutions without BC.

Izumi-kun avatar Feb 14 '25 11:02 Izumi-kun