yii2
yii2 copied to clipboard
Allows set named views in `ContentDecorator::$viewFile`
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
| Fixed issues |
Thank you for putting effort in the improvement of the Yii framework. We have reviewed your pull request.
Unfortunately a use case is missing. It is required to get a better understanding of the pull request and helps us to determine the necessity and applicability of the suggested change to the framework.
Could you supply us with a use case please? Please be as detailed as possible and show some code!
Thanks!
This is an automated comment, triggered by adding the label pr:missing usecase.
@bizley old implementation not support named views, look to updated example
Wouldn't be better to resolve view file in View::beginContent()? Passing view name as viewFile property looks a little bit off...
@rob006 View::beginContent() use $viewFile parameter and we can't change it
Your PR already assumes that you pass view name as first argument of beginContent(). Resolving name in this method will reduce number of places where view name is used as viewFile.
Codecov Report
Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.
Project coverage is 48.02%. Comparing base (
b0aa6ab) to head (da8275f).
| Files | Patch % | Lines |
|---|---|---|
| framework/widgets/ContentDecorator.php | 0.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #19624 +/- ##
=======================================
Coverage 48.02% 48.02%
=======================================
Files 445 445
Lines 43892 43892
=======================================
Hits 21080 21080
Misses 22812 22812
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.