yii2 icon indicating copy to clipboard operation
yii2 copied to clipboard

PHPDoc in Session incorrect?

Open robsch opened this issue 3 years ago • 7 comments

In https://github.com/yiisoft/yii2/blob/master/framework/web/Session.php isn't the @property-read declaration for $cookieParams and $cacheLimiter incorrect? Shouldn't it be just @property?

I didn't check the other properties. There might be further ones. Just stumbled over it.

robsch avatar Aug 18 '22 17:08 robsch

Indeed this is incorrect. Could you please prepare PR fixing it?

bizley avatar Aug 18 '22 19:08 bizley

It should be fixed in https://github.com/yiisoft/yii2/blob/master/build/controllers/PhpDocController.php since this part of phpdoc is generated.

samdark avatar Aug 18 '22 22:08 samdark

@samdark this trash can't work correctly

WinterSilence avatar Aug 19 '22 02:08 WinterSilence

Yes it can if fixed :)

samdark avatar Aug 19 '22 07:08 samdark

@samdark it's already fixed in yii\apidoc\models\Context::handlePropertyFeature()

WinterSilence avatar Aug 19 '22 07:08 WinterSilence

If it doesn't work properly then it's not fixed.

samdark avatar Aug 19 '22 09:08 samdark

@samdark i mean method in API package better, because check setters/getters only in classes extended BaseObject

WinterSilence avatar Aug 19 '22 09:08 WinterSilence