yii2 icon indicating copy to clipboard operation
yii2 copied to clipboard

dark background on error view when using dark theme

Open nilsburg opened this issue 3 years ago • 4 comments

What steps will reproduce the problem?

On the latest Google Chrome version when using a dark theme on the OS (Windows 10) it sets the default page color to black instead of white.

This makes the error page unreadable (look at the provided screenshots)

Setting the background color to white on the body element solves it. I could make a PR but I am not sure where the styles are located.

What is the expected result?

To see the error page with white background (using Windows 10 light theme): image

What do you get instead?

Using Windows 10 dark theme image

Additional info

Q A
Yii version 2.0.45
PHP version 7.4
Operating system Windows 10
Browser Google Chrome 98.0.4758.102

Funding

  • You can sponsor this specific effort via a Polar.sh pledge below
  • We receive the pledge once the issue is completed & verified
Fund with Polar

nilsburg avatar Feb 24 '22 09:02 nilsburg

I'm not sure what is going here but did you put word dark before return and expect it to work?

bizley avatar Feb 24 '22 10:02 bizley

Ohh, my bad, this is just to show the contrast, right?

bizley avatar Feb 24 '22 10:02 bizley

Ohh, my bad, this is just to show the contrast, right?

Yes, I put the string dark on purpose to force the error page.

nilsburg avatar Feb 24 '22 10:02 nilsburg

error view use outdated highlightJs, need update library and theme

WinterSilence avatar Feb 26 '22 14:02 WinterSilence