yii2 icon indicating copy to clipboard operation
yii2 copied to clipboard

18467 set requestedparams available in beforeaction

Open djidji01 opened this issue 4 years ago • 3 comments

Q A
Is bugfix?
New feature?
Breaks BC?
Tests pass? ✔️
Fixed issues #18467

Inspired by #18470 PL, this is refactoring for enhancement suggested in #18467 issue.

djidji01 avatar Jan 18 '21 18:01 djidji01

Thank you for putting effort in the improvement of the Yii framework. We have reviewed your pull request.

In order for the framework and your solution to remain stable in the future, we have a unit test requirement in place. Therefore we can only accept your pull request if it is covered by unit tests.

Could you add these please?

Thanks!

P.S. If you have any questions about the creation of unit tests? Don't hesitate to ask for support. More information about unit tests

This is an automated comment, triggered by adding the label pr:request for unit tests.

yii-bot avatar Jan 19 '21 09:01 yii-bot

Need more time to recheck and prepare it for release.

samdark avatar Mar 01 '21 21:03 samdark

Everything looks fine!

djidji01 avatar Mar 02 '21 05:03 djidji01