yii2-mongodb icon indicating copy to clipboard operation
yii2-mongodb copied to clipboard

Fixed #312 ActiveFixture::load() doesn't populate data with _id

Open Lisio opened this issue 5 years ago • 4 comments

Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues #312

Lisio avatar Jun 02 '20 04:06 Lisio

Thank you for putting effort in the improvement of the Yii framework. We have reviewed your pull request.

In order for the framework and your solution to remain stable in the future, we have a unit test requirement in place. Therefore we can only accept your pull request if it is covered by unit tests.

Could you add these please?

Thanks!

P.S. If you have any questions about the creation of unit tests? Don't hesitate to ask for support. More information about unit tests

This is an automated comment, triggered by adding the label pr:request for unit tests.

yii-bot avatar Jun 10 '20 14:06 yii-bot

The fix looks good. @Lisio is it possible to add a test for it? Then I'll merge it.

samdark avatar Jun 10 '20 14:06 samdark

@samdark Is it possible to merge it? Or are you waiting for tests?

igorbelikov avatar Apr 27 '24 23:04 igorbelikov

Yes, tests are necessary.

samdark avatar May 06 '24 11:05 samdark