yii2-mongodb icon indicating copy to clipboard operation
yii2-mongodb copied to clipboard

Transaction support

Open Lisio opened this issue 5 years ago • 8 comments

Q A
Is bugfix? no
New feature? yes
Breaks BC? no
Tests pass? n/a
Fixed issues

Lisio avatar May 25 '19 00:05 Lisio

Something wrong with the tests, current master also fails.

Lisio avatar May 25 '19 01:05 Lisio

Thank you for putting effort in the improvement of the Yii framework. We have reviewed your pull request.

In order for the framework and your solution to remain stable in the future, we have a unit test requirement in place. Therefore we can only accept your pull request if it is covered by unit tests.

Could you add these please?

Thanks!

P.S. If you have any questions about the creation of unit tests? Don't hesitate to ask for support. More information about unit tests

This is an automated comment, triggered by adding the label pr:request for unit tests.

yii-bot avatar May 28 '19 17:05 yii-bot

Do we need to use version 1.1.8 of mongodb extension for php 5.5? Session parameter is only compatible with 1.4.0 which is compatible with php 5.5.

Lisio avatar Jan 12 '20 18:01 Lisio

No, we don't. Likely using precise as OS would help. Let's check it...

samdark avatar Jan 16 '20 16:01 samdark

But first, let's merge master into this branch...

samdark avatar Jan 16 '20 16:01 samdark

@Lisio tests seems to fail on 5.4.

samdark avatar Mar 04 '20 14:03 samdark

Testing environment fails to install correct version of mongodb library

configure: error: not supported. Need a PHP version >= 5.6.0 (found 5.4.45)
ERROR: `/tmp/pear/install/mongodb/configure --with-php-config=/home/travis/.phpenv/versions/5.4/bin/php-config' failed
MongoDB PHP Extension version:
MongoDB support => enabled
MongoDB extension version => 1.2.6

Lisio avatar Mar 04 '20 15:03 Lisio

Yeah :( Seems we need to do it manually:

  • https://blog.theodo.com/2015/11/set-up-mongodb-on-a-travis-container-2/
  • https://github.com/mongodb/pymodm/blob/master/.travis.yml

samdark avatar Mar 04 '20 16:03 samdark