yii2-debug icon indicating copy to clipboard operation
yii2-debug copied to clipboard
verified publisher icon yiisoft

Update Module.php to fix assets register

Open niciz opened this issue 4 years ago • 5 comments

Register assets using the yii\web\View functions. In my application I have override the standard yii\web\View in order to add CSP nonce to each scripts loaded with View functions. Unfortunately yii-debug module doesn't use those functions to load assets. This is the fix.

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌
Fixed issues none

niciz avatar Oct 27 '21 13:10 niciz

@niciz that breaks these special cases when asset manager isn't available.

samdark avatar Oct 28 '21 12:10 samdark

@niciz I haven't seen extra commits. Now it looks alright. Would you please add a line for CHANGELOG? Thanks.

samdark avatar May 22 '23 19:05 samdark

Also please merge master into your branch.

samdark avatar May 22 '23 19:05 samdark

Hi @samdark sorry for late reply. Yes I fixed it and currently I'm using it in production without problems. Merged and added changes to CHANGELOG.md

Let me know if you need something else.

niciz avatar May 23 '23 08:05 niciz

Seems tests are broken because of the changes. Would you please check these?

samdark avatar May 24 '23 11:05 samdark