yii2-authclient icon indicating copy to clipboard operation
yii2-authclient copied to clipboard

Get rid of deprecation warnings for rawurlencode() and strpos() (#380)

Open g41797 opened this issue 2 years ago • 4 comments

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #380

"Deprecated" warning now showed for trim(), but it should be fixed in UrlManager.php (another repo)

devenv:

  • PhpStorm 2023.3.1
  • PHP 8.3.1
  • Xdebug v3.3.1

g41797 avatar Dec 29 '23 12:12 g41797

PR Summary

  • Improved Null Handling in 'OAuth1.php' In the file 'OAuth1.php', a series of changes have been made to ensure the system does not encounter unexpected problems if some values are missing or undefined. This involves using a null coalescing operator to flag certain items as empty strings if they're not present. The improved handling includes:
    • The URL
    • The method
    • The result of http_build_query
    • The consumer secret
    • The token secret

This results in a more robust behavior when these values aren't provided, reducing the risk of system errors and promoting smoother system operation overall.

what-the-diff[bot] avatar Dec 29 '23 12:12 what-the-diff[bot]

@g41797 do you want to fix the rest of compatibility issues? See tests failing.

samdark avatar Jan 02 '24 13:01 samdark

"Deprecated" warning (showed for trim()) are fixed by PR#20090

g41797 avatar Jan 02 '24 14:01 g41797

Merged that one.

samdark avatar Jan 03 '24 07:01 samdark