yii icon indicating copy to clipboard operation
yii copied to clipboard

PHP 8.3 compatibility

Open marcovtwout opened this issue 1 year ago • 1 comments

Q A
Is bugfix?
New feature?
Breaks BC?
Tests pass? ✔️
Fixed issues https://github.com/yiisoft/yii/issues/4552

marcovtwout avatar Jun 04 '24 08:06 marcovtwout

@samdark I ran into an issue with PHP 8.3 and phpunit for tests that use @runInSeparateProcess. Automated tests are failing with:

PHPUnit_Framework_Exception: PHP Notice:  stream_get_contents(): Read of 8192 bytes failed with errno=9 Bad file descriptor in Standard input code on line 59
PHP Stack trace:
PHP   1. {main}() Standard input code:0
PHP   2. __phpunit_run_isolated_test() Standard input code:100
PHP   3. stream_get_contents($stream = resource(2) of type (stream)) Standard input code:59

I applied some local patches for now and the tests are running now, but am not entirely sure they are the definitive solution. Apperantly similar issues were found on Yii2 as well, could you comment on the appropiate solution for yii1?

Related issues:

  • https://github.com/sebastianbergmann/phpunit/pull/4486
  • https://github.com/sebastianbergmann/phpunit/issues/3965
  • https://github.com/sebastianbergmann/phpunit/issues/3952

marcovtwout avatar Jun 04 '24 13:06 marcovtwout

Hey @marcovtwout ,

Thanks for your work on Yii and the PHP community and on this... do we have a date or estimate for releasing this 8.3 compatibility? We are about to test this.. we are already on 8.1 and migrating to 8.3 now.

o//

mlpassos avatar Sep 13 '24 18:09 mlpassos

@marcovtwout merged compatibility patch.

samdark avatar Sep 18 '24 11:09 samdark