yii icon indicating copy to clipboard operation
yii copied to clipboard

Published 20 hours ago • verified publisher icon yiisoft

Param fix

Open olleharstedt opened this issue 3 years ago • 4 comments

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌
Tests pass? ✔️
Fixed issues Param issue in function docblock

olleharstedt avatar Aug 08 '22 13:08 olleharstedt

itemAt accepts mixed, so this change makes sense.

olleharstedt avatar Aug 08 '22 13:08 olleharstedt

The class implements https://www.php.net/manual/en/class.arrayaccess.php which by now defines the param as $mixed. Is this the excepion in the source code or are there more similar changes to be made?

marcovtwout avatar Aug 08 '22 13:08 marcovtwout

The class implements https://www.php.net/manual/en/class.arrayaccess.php which by now defines the param as $mixed. Is this the excepion in the source code or are there more similar changes to be made?

No idea, honestly. Want me to grep around for array access interface?

olleharstedt avatar Aug 08 '22 13:08 olleharstedt

Pushed some more fixes. Skipped CCache, since it's only accepting string. Also skipping CList.

olleharstedt avatar Aug 08 '22 14:08 olleharstedt

@marcovtwout This can be merged :)

olleharstedt avatar Aug 29 '22 09:08 olleharstedt