yii-sentry icon indicating copy to clipboard operation
yii-sentry copied to clipboard

Published 20 hours ago • verified publisher icon yiisoft

Trace

Open gluck1986 opened this issue 3 years ago • 12 comments

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ✔️
Fixed issues https://github.com/yiisoft/yii-sentry/issues/18

gluck1986 avatar Aug 21 '22 18:08 gluck1986

@gluck1986 Thanks for your contribution! Do you have time for tests?

arogachev avatar Sep 08 '22 06:09 arogachev

this tests core functionality, auto transactions, and breadcrumbs. @arogachev

gluck1986 avatar Sep 22 '22 18:09 gluck1986

There is a something problem with the Rector after merge changes from master. @xepozz

gluck1986 avatar Oct 01 '22 16:10 gluck1986

Need to do a research, but I don't have time for this. Could you play rector locally please?

xepozz avatar Oct 01 '22 17:10 xepozz

Need to do a research, but I don't have time for this. Could you play rector locally please?

i see, rector cannot push. Run git push fatal: You are not currently on a branch. localy rector works

gluck1986 avatar Oct 01 '22 21:10 gluck1986

now all are fine, because rector has no changes to push) May be is it correct behaviour?

gluck1986 avatar Oct 01 '22 21:10 gluck1986

The most secure are the permissions of the organization.

terabytesoftw avatar Oct 01 '22 21:10 terabytesoftw

@arogachev You are welcome. So what is next? Can i help to speed up the development of this?

gluck1986 avatar Oct 10 '22 14:10 gluck1986

Thanks for resolving most of discussions.

We had an idea about merging it to a separate branch and continue from there. But regardless of that what I've written is actual. We need to decompose it into smaller parts and add tests to increase code coverage as close as possible to 100%. Do you have time for that? Maybe start with something small like breadcrumbs or something else?

arogachev avatar Oct 12 '22 12:10 arogachev

Thanks for resolving most of discussions.

We had an idea about merging it to a separate branch and continue from there. But regardless of that what I've written is actual. We need to decompose it into smaller parts and add tests to increase code coverage as close as possible to 100%. Do you have time for that? Maybe start with something small like breadcrumbs or something else?

Good idea. Then I will do the integration of breadcrumbs. What are we going to do with the pull request?

gluck1986 avatar Oct 12 '22 16:10 gluck1986

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

codecov[bot] avatar Oct 12 '22 17:10 codecov[bot]

Good idea. Then I will do the integration of breadcrumbs.

Great!

What are we going to do with the pull request?

As for this PR, let's leave it open for now.

Also ideally we need to test it with demo and real Sentry account.

arogachev avatar Oct 13 '22 05:10 arogachev

@gluck1986 do you have time to work on it further?

samdark avatar Apr 05 '25 06:04 samdark