queue icon indicating copy to clipboard operation
queue copied to clipboard

Use `yiisoft/yii-console` with optional.

Open terabytesoftw opened this issue 2 years ago • 5 comments

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

terabytesoftw avatar Nov 21 '23 15:11 terabytesoftw

PR Summary

  • Update to README.md for clearer usage instructions

    • Instructions for usage with Yii Console and Symfony Console were added. Adding these equips users with more ways to use the product.
    • An actionable code example for configuring a logger with yiisoft/log-target-file was provided, making it easier for users to set up logging functionalities.
    • Instructions for adding aliases for the logger were given to allow users to use more convenient shortcuts for their tasks.
  • Addition new helper files

    • Three new files were added (bin/definitions.php, bin/queue, bin/queue.bat). These files are likely aimed at expanding the functionality or streamlining the usage of the product.
  • Modification of composer.json for enhanced package setup

    • "yiisoft/config" package was added to the dependencies. This aids in improved configuration management of the project
    • "bin/queue" was included in the "bin" section. This implies the addition of new command-line functionalities.
  • Updates to src/Command/ListenCommand.php and src/Command/RunCommand.php for consistent return values

    • Rather than using a symbolic constant (ExitCode::OK), the execute method in both files now consistently return 0 to signify success. This makes the code more straightforward to understand and follow.

what-the-diff[bot] avatar Nov 21 '23 15:11 what-the-diff[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (eba0486) 94.31% compared to head (7910e61) 94.31%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #178   +/-   ##
=========================================
  Coverage     94.31%   94.31%           
  Complexity      340      340           
=========================================
  Files            40       40           
  Lines           915      915           
=========================================
  Hits            863      863           
  Misses           52       52           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 22 '23 14:11 codecov[bot]

https://github.com/yiisoft/actions/pull/66 fix mutation actions.

terabytesoftw avatar Nov 23 '23 17:11 terabytesoftw

I think we need to adjust it the same way as https://github.com/yiisoft/db-migration/commit/e0e4e498c3593149015b12478c377ed8bfc73e06

samdark avatar Dec 25 '23 14:12 samdark