db icon indicating copy to clipboard operation
db copied to clipboard

Fix #888 issue

Open evil1 opened this issue 9 months ago • 4 comments

Q A
Is bugfix? ✔️
New feature?
Breaks BC? ✔️
Fixed issues #888

Relative PRs:

  • https://github.com/yiisoft/db-pgsql/pull/398

evil1 avatar Mar 28 '25 09:03 evil1

Codecov Report

Attention: Patch coverage is 94.84536% with 5 lines in your changes missing coverage. Please review.

Project coverage is 99.18%. Comparing base (43abebf) to head (b41aa4c).

Files with missing lines Patch % Lines
src/QueryBuilder/AbstractDMLQueryBuilder.php 96.72% 2 Missing :warning:
src/QueryBuilder/AbstractQueryBuilder.php 66.66% 2 Missing :warning:
src/Command/AbstractCommand.php 90.90% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #948      +/-   ##
============================================
- Coverage     99.24%   99.18%   -0.07%     
- Complexity     1554     1571      +17     
============================================
  Files            98      100       +2     
  Lines          3852     3913      +61     
============================================
+ Hits           3823     3881      +58     
- Misses           29       32       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Mar 28 '25 09:03 codecov[bot]

Looks like Command::insertBatch() should return InsertBatchCommand or CommandCollection instance which has execute() method.

Tigrov avatar Mar 30 '25 04:03 Tigrov

Or perhaps needs to make it executable

Commnad::insertBatch() {
    ...
    $statements = $this->getQueryBuilder()->insertBatch($table, $rows, $columns);
  
    foreach ($statements as $statement) {
        $this->setRawSql($statement->getSql())->bindValues($statement->getParams())->execute();
    }
    ...
}

Tigrov avatar Mar 30 '25 04:03 Tigrov

https://github.com/yiisoft/db/issues/893

samdark avatar Mar 31 '25 07:03 samdark