db
db copied to clipboard
Fix #888 issue
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ✔️ |
| Fixed issues | #888 |
Relative PRs:
- https://github.com/yiisoft/db-pgsql/pull/398
Codecov Report
Attention: Patch coverage is 94.84536% with 5 lines in your changes missing coverage. Please review.
Project coverage is 99.18%. Comparing base (
43abebf) to head (b41aa4c).
Additional details and impacted files
@@ Coverage Diff @@
## master #948 +/- ##
============================================
- Coverage 99.24% 99.18% -0.07%
- Complexity 1554 1571 +17
============================================
Files 98 100 +2
Lines 3852 3913 +61
============================================
+ Hits 3823 3881 +58
- Misses 29 32 +3
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Looks like Command::insertBatch() should return InsertBatchCommand or CommandCollection instance which has execute() method.
Or perhaps needs to make it executable
Commnad::insertBatch() {
...
$statements = $this->getQueryBuilder()->insertBatch($table, $rows, $columns);
foreach ($statements as $statement) {
$this->setRawSql($statement->getSql())->bindValues($statement->getParams())->execute();
}
...
}
https://github.com/yiisoft/db/issues/893