db-elasticsearch icon indicating copy to clipboard operation
db-elasticsearch copied to clipboard

Port to Yii2 (Initial Commit).

Open terabytesoftw opened this issue 2 years ago • 4 comments

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

terabytesoftw avatar Apr 15 '23 20:04 terabytesoftw

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@092d040). Click here to learn what that means. Patch has no changes to coverable lines.

:exclamation: Current head af2a755 differs from pull request most recent head 87e30a6. Consider uploading reports for the commit 87e30a6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #46   +/-   ##
=========================================
  Coverage          ?   57.04%           
  Complexity        ?      170           
=========================================
  Files             ?        6           
  Lines             ?      440           
  Branches          ?        0           
=========================================
  Hits              ?      251           
  Misses            ?      189           
  Partials          ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Apr 15 '23 21:04 codecov[bot]

Also, there's https://github.com/elastic/elasticsearch-php. Are we sure we want our own implementation for Yii3?

samdark avatar Apr 16 '23 15:04 samdark

Also, there's https://github.com/elastic/elasticsearch-php. Are we sure we want our own implementation for Yii3?

If you check the client, and compare it with the api of this library, this is by far much better.

terabytesoftw avatar Apr 16 '23 15:04 terabytesoftw

Also, there's https://github.com/elastic/elasticsearch-php. Are we sure we want our own implementation for Yii3?

However, if you think it's better to use the php library, then let's drop this package, just like the db packages, which you think aren't worth porting.

terabytesoftw avatar Apr 16 '23 15:04 terabytesoftw