crandalf
crandalf copied to clipboard
yihui
Revcheck rstudio/rticles
Hi @yihui,
Can you give me access to this repo so that I can maybe trigger some revdev check using this kind of existing branch ?
rticles is kind of ready for release and I wanted to try use this service as I think it is part of your workflow now. Should I do that in a fork instead ?
Thanks.
You are already a collaborator in this repo. I don't know why even I can't see the button "Re-run jobs" in Github Actions. Anyway, I just merged master into this branch and pushed to trigger a new check.
The revdep checks have passed, but this commit failed the R CMD checks: https://github.com/rstudio/rticles/commit/e283b1f0e5e7a5ee49104344a3b343977bdd0e41 Once you fix it, I think we can submit to CRAN.
This is fixed. I forgot to check that my last commit worked, and failure got lost in email notification. 😞
And if I understand correctly, no need to push - there is just a new run of the workflow to trigger because nothing ever change in this PR, is that right ?
If so, how about I modify slightly the main action so that we can trigger a workflow run from command line ? This can be done using gh CLI and I often use it in my repo for testing github action. I believe it would be from any working directory :
gh workflow -R yihui/crandalf run rev-check.yaml --ref check-rticles
and then you can continue using gh CLI to see the result of open the webpage.
From within local crandalf git repo it would be
gh workflow run rev-check.yaml --ref check-rticles
And if I understand correctly, no need to push - there is just a new run of the workflow to trigger because nothing ever change in this PR, is that right ?
That's right. I pushed only because I wanted to keep this check-rticles branch up-to-date with master.
Yes, feel free to use the command line gh.
I just started checking the package on win-builder. If I don't see problems, I'll submit to CRAN later today.
It seems like rev-check passes now: https://github.com/yihui/crandalf/actions/runs/1562984888