Eric Fang
Eric Fang
Since I am responsible for many of the decreasing the coverage in the recent PRs, I want to take a look at this next.
@utam0k Understood. I will take a look at #1348. For #279, there are a number of fixes I already noticed, so I will fix them quickly. I won't go into...
There has been no activity in this issue and `youki` has changed a lot since this issue has been filed. Please re-open if there is objections.
@YJDoc2 is there still pending action items for this issue?
For future reference, `youki` should be single threaded. We use fork to create and set up the container init process. Forking without immediately exec into a new binary in multi-threaded...
Based on the runtime spec, when the prestart hook fails, the container should be stopped and kills the container process. The container should end in the state of `STOPPED`. Reference:...
Let me spend sometime next week looking into this.
I will take care of the detached and foreground mode. Although the core of this issue seems to be unrelated to `detached` anymore lol.
Looks like `test-windows` is broken unrelated to my change. I tried tip of the tree and the test still fails. ``` === Failed === FAIL: cmd TestE2E_RerunFails/first_run_has_errors,_abort_rerun (0.39s) main_e2e_test.go:69: assertion...
@dnephin Please let me know if there is anything you would like me to follow up :)