NetRevisionTask icon indicating copy to clipboard operation
NetRevisionTask copied to clipboard

Published 20 hours ago • verified publisher icon ygoe

Interactive API extension added

Open 0x6d61726b opened this issue 4 years ago • 2 comments

Hello Yves,

I have added an Interactive API as extension to the already present static methods, so I can use NetRevisionTask.dll be called and queried by other assemlies, e.g. to integrate it with an external build flow for embedded devices.

Please let me know what you think.

Best regards, Mark

0x6d61726b avatar Jan 02 '21 17:01 0x6d61726b

This PR has two merge conflicts, distributed over multiple places:

  • The targets file uses another AfterTargets/BeforeTargets attribute, see #17.
  • The main Common.GetVersion method has different parameters. I see the number of parameters is increasing here. Maybe it would make sense to factor those out into a separate options class with all those properties?

I'm sorry to have caused these conflicts. I first needed to fix another issue. And before publishing it as a new version, I figured I could try to address these PRs now, too.

ygoe avatar Feb 27 '21 22:02 ygoe

The merge conflicts have been resolved, however patch-03 branch needed to be merged because Interactive API needs functionality implemented there.

Regarding Common.GetVersion I did appended the new parameters, so for compatibility, it should not be an issue.

0x6d61726b avatar Jul 16 '23 13:07 0x6d61726b