NetRevisionTask icon indicating copy to clipboard operation
NetRevisionTask copied to clipboard

Implemented resolving AssemblyMetadata, build configuration format strings and build error on dirty repo

Open 0x6d61726b opened this issue 4 years ago • 4 comments

Hello Yves,

I have extended Net Revision Task with the following changes:

  • Implemented resolving of AssemblyMetadata attributes value format strings (enabled by default)
  • BuildTime is updated if GetVersion() is called (otherwise the build time stays constant until the Solution is reloaded)
  • Added {bconf}, {BCONF} and {bconf:<sep>:<ref>} format strings to resolve build configuration names
  • Implemented a RegEx match pattern to trigger a build error if the repository contains modifications

Please let me know if you don't agree with the changes or see potential for optimizations.

Best regards, Mark

0x6d61726b avatar Oct 17 '20 19:10 0x6d61726b

Hello Ives,

I added another patch to avoid the error message "Revision ID cannot be truncated to dotted-numeric" when the repository was empty and did not yet receive a tag. I can't tell if the solution I have chosen with 56485af is the way to go, but it works for the issue I currently had.

Best regards, Mark

0x6d61726b avatar Nov 12 '20 19:11 0x6d61726b

Just wanted to give a quick feedback. I'm very busy with other time-critical projects at the moment but these changes sound interesting and I'll take a look at them. Please don't be too sad if I won't make it anymore this year.

ygoe avatar Nov 18 '20 19:11 ygoe

Thanks for your feedback, Yves. I made a local build and can work with it for now. Take your time.

0x6d61726b avatar Nov 18 '20 22:11 0x6d61726b

Merged latest changes and fixed conflicts.

0x6d61726b avatar Jul 16 '23 11:07 0x6d61726b