Yasser Tahiri

Results 67 comments of Yasser Tahiri

> Actually, `numpy` has a pretty big artifact. Should we create `pydantic-numpy-types`? 😅 Can't deny the same regarding the https://github.com/pydantic/pydantic-extra-types/issues/24 but I guess it can be good if we have...

> Maybe the extra `all` can be created so people can do `pip install pydantic-extra-types[all]`, or the extra `numpy`. Or... Just don't install `numpy`, and show a message like "You...

To streamline the process and maintain a sense of progress, I suggest starting by merging the types that are already available. This step will allow us to consolidate the existing...

> Does this requires more specificity in the naming, as there are more than one type of OTP? For example: HOTP and TOTP > > The “H” in HOTP stands...

> Can someone clarify if pydantic_extra_types will work on pydantic v1. > > I am unable to migrate due to dependency issues at the moment Hello @XChikuX 👋🏻 No, it...

> I'm a bit unclear on the usage here. > > I think the api should perhaps be more like > > ```python > class LoginForm(BaseModel): > password: str #...

Hey @samuelcolvin I think we have schema close to this: ```py from pydantic import BaseModel from pydantic_extra_types import OTPToken import pyotp class LoginForm(BaseModel): username: str password: str ot_token: OTPToken #...

@samuelcolvin all the changes fixed, This Pull request is ready to merge

@samuelcolvin This one also works fine locally you can test it before we merge it