authx icon indicating copy to clipboard operation
authx copied to clipboard

✨ Pydantic v2 migration

Open yezz123 opened this issue 2 years ago • 9 comments

yezz123 avatar Jun 24 '23 20:06 yezz123

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
authx ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 10:54pm
authx-old ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 10:54pm

vercel[bot] avatar Jun 24 '23 20:06 vercel[bot]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (90dd778) 90.24% compared to head (1c8a1e4) 90.30%. Report is 2 commits behind head on main.

:exclamation: Current head 1c8a1e4 differs from pull request most recent head fe8d036. Consider uploading reports for the commit fe8d036 to get more accurate results

Files Patch % Lines
authx/schema.py 80.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #470      +/-   ##
==========================================
+ Coverage   90.24%   90.30%   +0.05%     
==========================================
  Files          26       25       -1     
  Lines        1282     1165     -117     
  Branches      205      183      -22     
==========================================
- Hits         1157     1052     -105     
+ Misses         83       81       -2     
+ Partials       42       32      -10     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 24 '23 20:06 codecov[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Aug 18 '23 16:08 sonarqubecloud[bot]

@yezz123 is there anything I can do to help you land this PR?

patrick91 avatar Sep 30 '23 20:09 patrick91

Hey, @patrick91, thanks for reaching out and your willingness to help 🙏🏻

I really appreciate it. I've been taking some time off recently, but I'm now back and ready to start reviewing the changes in this PR and push some updates.

My main idea of supporting both versions of Pydantic sounds excellent and will definitely help maintain broader compatibility.

Please let me know if you have any specific suggestions or areas you'd like to contribute to.

Thanks again for your support 🙌🏻

yezz123 avatar Oct 01 '23 03:10 yezz123

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 15 '23 03:10 sonarqubecloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Nov 28 '23 22:11 sonarqubecloud[bot]

any updates?

artemonsh avatar Jan 16 '24 17:01 artemonsh

Any updates?

I'm thinking of keeping this one until I finish the documentation and then I will get back to it, it's on my milestone 🙏🏻

yezz123 avatar Jan 16 '24 21:01 yezz123