RegTR icon indicating copy to clipboard operation
RegTR copied to clipboard

Question about calculating the overlapping regions of source cloud and target cloud

Open CorgiBoyG opened this issue 8 months ago • 2 comments

Your work is great, I've recently been debugging your code to compare algorithms, but I've noticed that there seems to be an ambiguity. In pointcloud.py, when you calculate the overlap region between the source and target point clouds, you first fill tgt_corr, src_corr with a value of -1, and then calculate the correspondence: src_corr_is_mutual = np.logical_and(tgt_corr[src_corr] == np.arange(len(src_corr)), src_corr > 0). Shouldn't "src_corr > 0" be adjusted to "src_corr >= 0", because the index value starts from 0, and it's correct if for a point in the source point cloud, it has to be indexed to 0 for the target point.

CorgiBoyG avatar Jun 26 '24 06:06 CorgiBoyG