docs icon indicating copy to clipboard operation
docs copied to clipboard

1/8 Create lifecycle page and review component introduction

Open rlasjunies opened this issue 5 years ago • 3 comments

this is the 1st PR of several (should be 8)

@jstarry I did not, yet, review the content providing more interesting component. I will do it after the split of the PR

rlasjunies avatar May 08 '20 16:05 rlasjunies

@jstarry I've replaced SimpleComponent by a ExampleComponent in the "main page" of Components

I am not so convinced ... I feel it heavy to read ... I still prefer the 1st proposal ;-p I let you review the PRs ...

rlasjunies avatar May 08 '20 18:05 rlasjunies

@jstarry @teymour-aldridge Guys, as there is a lot of changes, it is complicate to review/follow. To help, I am temporarly publishing the doc here

Doing so, you could see what it looks like. Let me know if this is something you would like.

@jstarry We would appreciate your feedbacks on:

  • Component page: you were expecting something a bit more "rich" than the 1st proposal. Does it fit? ... or it's too complex

  • Properties In the example I add props field to the struct and props comparison in the change method. That complexify a bit. Do you prefer that I move this code only in the

Optimizing rendering in the change method

BIG thanks to you Teymour!

rlasjunies avatar May 10 '20 16:05 rlasjunies

This makes things a lot easier to follow.

On 10 May 2020, at 17:57, Richard Lasjunies [email protected] wrote:

@jstarry https://github.com/jstarry @teymour-aldridge https://github.com/teymour-aldridge Guys, as there is a lot of changes, it is complicate to review/follow. To help, I am temporarly publishing the doc here https://rlasjunies.github.io/yew_doc_branches_merged/ Doing so, you could see what it looks like. Let me know if this is something you would like.

@jstarry https://github.com/jstarry We would appreciate your feedbacks on:

Component page https://rlasjunies.github.io/yew_doc_branches_merged/concepts/components/index.html: you were expecting something a bit more "rich" than the 1st proposal. Does it fit? ... or it's too complex

Properties https://rlasjunies.github.io/yew_doc_branches_merged/concepts/components/properties.html In the example I add props field to the struct and props comparison in the change method. That complexify a bit. Do you prefer that I move this code only in the

Optimizing rendering in the change method

BIG thanks to you Teymour!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/yewstack/docs/pull/82#issuecomment-626357501, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKFSTPJQMJLLQBBPYM77MSTRQ3MHVANCNFSM4M4I5EPQ.

teymour-aldridge avatar May 10 '20 16:05 teymour-aldridge