aligned_layer icon indicating copy to clipboard operation
aligned_layer copied to clipboard

fix: aligned layer service manager call service manager base init

Open NicolasRampoldi opened this issue 1 year ago • 1 comments

[!NOTE]
The rewardsInitializator address was set to the same as the initialOwner of AlignedLayerServiceManager.

Description

  • This PR updates the AlignedLayerServiceManager contract to improve the consistency and security of the initialization process by leveraging the existing mechanisms in the ServiceManagerBase contract.

To Test

  • Try deployment and normal flow.

NicolasRampoldi avatar Aug 22 '24 16:08 NicolasRampoldi

Changes to gas cost

Generated at commit: 977e077b213b308bccfa2da4ff7161a4fa19c291, compared to commit: 53967dbbc83b5ae63ca4ca78cb0a3651e67ada37

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
AlignedLayerServiceManager batchesState
createNewTask
-66 ✅
+22 ❌
-10.80%
+0.04%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
AlignedLayerServiceManager 4,365,704 (+40,586) batchesState
createNewTask
545 (-66)
51,138 (+22)
-10.80%
+0.04%
545 (-66)
51,309 (+22)
-10.80%
+0.04%
545 (-66)
51,234 (+22)
-10.80%
+0.04%
545 (-66)
51,888 (+22)
-10.80%
+0.04%
256 (0)
256 (0)

github-actions[bot] avatar Aug 22 '24 16:08 github-actions[bot]