react-native-dynamic-tab-view
react-native-dynamic-tab-view copied to clipboard
remove unnecessary unsafe componentWillReceiveProps
use this.props.selectedTab instead of state.selected and remove unnecessary logic inside componentWillReceiveProps
Hi @maherzaidoune Do you want to write testcases for this?
Hi @maherzaidoune Do you want to write testcases for this?
I don't see the need for writing test for just that commit while the whole project has no tests, anyway I'm using that in production with no problems, I'll write tests in weekend If I had time
@maherzaidoune Let me know if this is still valid. I will go ahead and merge it.
@maherzaidoune Let me know if this is still valid. I will go ahead and merge it.
I'm using that from my fork till now