react-native-dynamic-tab-view icon indicating copy to clipboard operation
react-native-dynamic-tab-view copied to clipboard

remove unnecessary unsafe componentWillReceiveProps

Open maherzaidoune opened this issue 4 years ago • 4 comments

use this.props.selectedTab instead of state.selected and remove unnecessary logic inside componentWillReceiveProps

maherzaidoune avatar Jun 05 '20 11:06 maherzaidoune

Hi @maherzaidoune Do you want to write testcases for this?

yeswanth avatar Jun 05 '20 11:06 yeswanth

Hi @maherzaidoune Do you want to write testcases for this?

I don't see the need for writing test for just that commit while the whole project has no tests, anyway I'm using that in production with no problems, I'll write tests in weekend If I had time

maherzaidoune avatar Jun 05 '20 11:06 maherzaidoune

@maherzaidoune Let me know if this is still valid. I will go ahead and merge it.

yeswanth avatar Oct 26 '20 04:10 yeswanth

@maherzaidoune Let me know if this is still valid. I will go ahead and merge it.

I'm using that from my fork till now

maherzaidoune avatar Oct 27 '20 19:10 maherzaidoune