Yeray Borges

Results 142 comments of Yeray Borges

> In looking at the documentation for this operator, I see a lot of good description about how to build the operator and how to configure it and use it,...

Hi @shreyakajbaje It seems you are using an old branch. There is some documentation about how to run the Operator tests (either in local or deploy mode) with a local...

Ok, that's weird, your error trace describes the uses of `./operator-sdk test local`, which makes me think your branch is lagging behind the `main`. Can you double-check if you are...

Finally, it was decided to use `addFirst` trick on the installation manager history handler to coordinate the execution, context about the discussion can be found in [Zulip](https://wildfly.zulipchat.com/#narrow/stream/174184-wildfly-developers/topic/.E2.9C.94.20Operation.20Result.20in.20a.20Complete.20Step)

@spyrkob Ideally yes, we can release installation-manager once we test this PR together with Prospero. Then we bump it on wildfly core and this would be rebased so we can...

@spyrkob Talking about testing strategy, this is what we have so far: * Management Operation unit tests: https://github.com/wildfly/wildfly-core/blob/main/installation-manager/src/test/java/org/wildfly/core/instmgr/InstMgrResourceTestCase.java * High-level commands using domain mode. See https://github.com/wildfly/wildfly-core/blob/main/testsuite/domain/src/test/java/org/jboss/as/test/integration/domain/installationmanager/InstallationManagerIntegrationTestCase.java#L104-L110, we create a specific...

> I'm not sure if there's a better way to avoid code duplication between the two @spyrkob I think it could have been enough by just adding the `:product-info` operation...

@spyrkob Reviewing your PR I found that there is an issue with the installation manager integration tests running on Windows. The failures here are not related to your PR. I...

@spyrkob Failures in this PR should be resolved with #6240 There was left one `File.lists` without a try/catch, so the stream was never closed and Windows (legitimately) complained about it....

@spyrkob Since there were no strong preferences, I've just merged https://github.com/wildfly/wildfly-core/pull/6240, you can rebase and incorporate the two minimal changes done in such a PR on the current one and...