Fix issue with radio button when choice is string and not object.

[revathskumar]

related #74

[stefanbuck]

Thanks for picking this up @revathskuma! I had a look on your solution and noticed that your fix would work for RadioButton only (which is definitely an improvement) but, I would prefer a generic solution see #75.

My idea would be to normalize the data upfront, before we pass them to the render process https://github.com/yeoman/yeoman-app/blob/d58650cfc94a4523104f67392e64c59e7afcf02e/src/browser/yo/adapter.js#L6. It shouldn't be that hard, but changes in this area require a solid test coverage. Unfortunately we have a lack of tests in some areas. I'm more than happy to support and guide you through the required changes.

[revathskumar]

Yes, I have seen #75. but since I am new to this code base I haven't tried for generic solution. But lemme try to work on it.

On Mon, Mar 28, 2016 at 9:41 PM, Stefan Buck [email protected] wrote:

Thanks for picking this up @revathskuma! I had a look on your solution and noticed that your fix would work for RadioButton only (which is definitely an improvement) but, I would prefer a generic solution see #75 https://github.com/yeoman/yeoman-app/issues/75.

My idea would be to normalize the data upfront, before we pass them to the render process https://github.com/yeoman/yeoman-app/blob/d58650cfc94a4523104f67392e64c59e7afcf02e/src/browser/yo/adapter.js#L6. It shouldn't be that hard, but changes in this area require a solid test coverage. Unfortunately we have a lack of tests in some areas. I'm more than happy to support and guide you through the required changes.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/yeoman/yeoman-app/pull/109#issuecomment-202465103

with regards, Revath S Kumar, Rubyist / JavaScripter / PHP

markdownblogger.herokuapp.com

www.phprepo.in revathskumar.com +919995436867

http://twitter.com/revathskumar http://www.linkedin.com/in/revathskumar http://www.gplus.to/rsk http://www.about.me/revathskumar http://www.phprepo.in/ http://www.github.com/revathskumar http://www.youtube.com/revathskumar http://blog.revathskumar.com https://foursquare.com/revathskumar [image: normal-1.png] http://careers.stackoverflow.com/revathskumar