grunt-usemin icon indicating copy to clipboard operation
grunt-usemin copied to clipboard

Fix for inconsistent line feed

Open lu4 opened this issue 9 years ago • 3 comments

Replacing the lines with original method not works for cases when the carrige return is inconsistent across the file, it makes the whole block not to get replaced because after concatenation you get a block which is different from original

lu4 avatar Oct 31 '15 08:10 lu4

Replacing the lines with original method not works for cases when the carrige return is inconsistent across the file,

Do you have a test case or example of this that fails without the patch you've supplied?

addyosmani avatar Jan 15 '16 10:01 addyosmani

I can confirm this patch resolves a bug causing the blocks not to be replaced on Windows. Great work @lu4

ThomasHambach avatar Mar 04 '16 06:03 ThomasHambach

Like Addy said, this needs a failing unit test so it can be verified

eddiemonge avatar Apr 07 '16 21:04 eddiemonge