grunt-usemin icon indicating copy to clipboard operation
grunt-usemin copied to clipboard

Add possibility to apply custom options to different flows

Open OlgaBielkina opened this issue 10 years ago • 13 comments

Ref issue: https://github.com/yeoman/grunt-usemin/issues/255

OlgaBielkina avatar Nov 12 '14 10:11 OlgaBielkina

// @stephanebachelier

sindresorhus avatar Nov 12 '14 18:11 sindresorhus

@sindresorhus :+1:

Might need a little more documentation about the multiple configurations but maybe we should create a cookbook as the README is already huge.

stephanebachelier avatar Nov 12 '14 23:11 stephanebachelier

Might need a little more documentation about the multiple configurations but maybe we should create a cookbook as the README is already huge.

:+1:

sindresorhus avatar Nov 16 '14 07:11 sindresorhus

@sindresorhus maybe we should accept this PR which is documented, and add a new issue for the cookbook

stephanebachelier avatar Dec 13 '14 00:12 stephanebachelier

Sure, but this still needs a test though.

sindresorhus avatar Dec 15 '14 05:12 sindresorhus

Also needed this functionality. Patched it into my own fork, which I am using in package.json now. Excellent patch.

Frank3K avatar Dec 31 '14 14:12 Frank3K

@OlgaBielkina we need a test to accept your PR. Can you provide one ?

stephanebachelier avatar Dec 31 '14 14:12 stephanebachelier

ping @OlgaBielkina

arthurvr avatar Feb 08 '15 13:02 arthurvr

Thannxxxx @OlgaBielkina! What do you think, @stephanebachelier?

arthurvr avatar Feb 12 '15 16:02 arthurvr

@OlgaBielkina I've reviewed your tests. I didn't get where you trigger the multiple flow.

stephanebachelier avatar Feb 21 '15 17:02 stephanebachelier

@stephanebachelier as far as I understand when you use multiple flows (profiles) all previous functionality should work the same. My tests show that it works for the dev profile. All except multiple targets. With previous code base it was not possible to add dev/prod profiles at all.

OlgaBielkina avatar Feb 21 '15 20:02 OlgaBielkina

@OlgaBielkina I will need to take some time to understand/review the whole thing. In #255 there are two kinds of demands: multiple targets and or be able to switch between dev or dist profile as you can read in #456

stephanebachelier avatar Feb 22 '15 00:02 stephanebachelier

@OlgaBielkina will take a deeper look soon. Sorry for the delay there was others issues that I needed to fix before.

stephanebachelier avatar Mar 10 '15 23:03 stephanebachelier